RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v12]

Jaikiran Pai jpai at openjdk.org
Thu May 22 10:51:07 UTC 2025


On Thu, 22 May 2025 01:29:12 GMT, Henry Jen <henryjen at openjdk.org> wrote:

>> This PR check the jar file to ensure entries are consistent from the central directory and local file header. Also check there is no duplicate entry names that could override the desired content by accident.
>
> Henry Jen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Validator to take a file, use term JAR file

src/jdk.jartool/share/classes/sun/tools/jar/Validator.java line 141:

> 139:      * NOTE: In order to check the encounter order based on the CEN listing,
> 140:      *       this implementation assumes CEN entries are to be added before
> 141:      *       add any LOC entries. That is, addCenEntry should be called before

This looks like a typo. Should have been "adding any ..."

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24430#discussion_r2102254941


More information about the core-libs-dev mailing list