RFR: 8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message [v5]

Per Minborg pminborg at openjdk.org
Thu May 22 13:46:57 UTC 2025


On Tue, 20 May 2025 10:54:44 GMT, He-Pin(kerr) <duke at openjdk.org> wrote:

>> Motivation:
>> When a user passes a wrong parameter, the current implementation throws an IllegalArgumentException with an error message `null`, which is not helpful.
>> 
>> Modification:
>> Add detail error messages.
>> 
>> Result:
>> Helpful messages.
>
> He-Pin(kerr) has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update src/java.base/share/classes/java/util/concurrent/AbstractExecutorService.java
>    
>    Co-authored-by: Viktor Klang <viktor.klang at oracle.com>
>  - Update src/java.base/share/classes/java/util/concurrent/AbstractExecutorService.java
>    
>    Co-authored-by: Viktor Klang <viktor.klang at oracle.com>

Looks good to me.

-------------

Marked as reviewed by pminborg (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23050#pullrequestreview-2861300123


More information about the core-libs-dev mailing list