RFR: 8357165: test java/lang/invoke/ClassValueTest.java fails intermittently [v2]

Chen Liang liach at openjdk.org
Thu May 22 14:27:59 UTC 2025


On Wed, 21 May 2025 17:09:29 GMT, Chen Liang <liach at openjdk.org> wrote:

>> The test was originally written with product builds in mind; it didn't consider the slowness of debug builds, thus causing tests to fail.
>> 
>> Also there was a bug in testWeakAgainstClassValue: the test need to flush the backing map in the class to have the weak value removed. It is fixed in this patch as well.
>> 
>> Testing: ClassValueTest repeated 10 times on windows-x64/linux-x64/macosx-aarch64/linux-aarch64 fastdebug.
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Increase timeout, add comment for adjust for debugging
>  - Merge branch 'master' of https://github.com/openjdk/jdk into fix/cv-test-problems
>  - Restore incorrectly removed annotation
>  - Fix problems with class value tests

The failing tier 1 tests on GitHub are gc ones. Thanks for the reviews! I think we are good to go.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25292#issuecomment-2901426835


More information about the core-libs-dev mailing list