RFR: 8355223: Improve documentation on @IntrinsicCandidate [v7]
Roger Riggs
rriggs at openjdk.org
Fri May 23 16:15:56 UTC 2025
On Wed, 21 May 2025 21:31:16 GMT, Chen Liang <liach at openjdk.org> wrote:
>> In offline discussion, we noted that the documentation on this annotation does not recommend minimizing the intrinsified section and moving whatever can be done in Java to Java; thus I prepared this documentation update, to shrink a "TLDR" essay to something concise for readers, such as pointing to that list at `vmIntrinsics.hpp` instead of "a list".
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>
> - More review updates
> - Merge branch 'master' of https://github.com/openjdk/jdk into doc/intrinsic-candidate
> - Move intrinsic to be a subsection; just one most common function of the annotation
> - Merge branch 'master' of https://github.com/openjdk/jdk into doc/intrinsic-candidate
> - Merge branch 'master' of https://github.com/openjdk/jdk into doc/intrinsic-candidate
> - Update src/java.base/share/classes/jdk/internal/vm/annotation/IntrinsicCandidate.java
>
> Co-authored-by: Raffaello Giulietti <raffaello.giulietti at oracle.com>
> - Shorter first sentence
> - Updates, thanks to John
> - Refine validation and defensive copying
> - 8355223: Improve documentation on @IntrinsicCandidate
The bulk of these comments belong in a design/rational doc for VM intrinsics, not in the javadoc of an annotation.
-------------
PR Review: https://git.openjdk.org/jdk/pull/24777#pullrequestreview-2864975777
More information about the core-libs-dev
mailing list