RFR: 8357145: CRC/Inflater/Deflater/Adler32 methods that take a ByteBuffer throw UOE if backed by shared memory segment
Alan Bateman
alanb at openjdk.org
Tue May 27 14:01:19 UTC 2025
On Tue, 20 May 2025 07:37:34 GMT, Per Minborg <pminborg at openjdk.org> wrote:
> This PR proposes to use ` JavaNioAccess::getBufferAdress` rather than `DirectBuffer::address` in the package `java.util.zip` so that `Buffer` instances backed by `MemorySegment` instances can be used.
>
> This PR passes tier1, tier2, and tier3 tests on multiple platforms and configurations.
Marked as reviewed by alanb (Reviewer).
I think the src changes are good. There are 13 methods across the 5 APIs that need tests for confined/shared/auto to ensure that we have all cases covered. The tests in the PR are okay but I think we will need a follow-on JBS issue to cover all the cases and avoid surprises.
-------------
PR Review: https://git.openjdk.org/jdk/pull/25321#pullrequestreview-2871212681
PR Comment: https://git.openjdk.org/jdk/pull/25321#issuecomment-2912622466
More information about the core-libs-dev
mailing list