RFR: 8357930: Amendment for JDK-8333664

Alexander Matveev almatvee at openjdk.org
Wed May 28 07:03:54 UTC 2025


On Wed, 28 May 2025 02:52:57 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

> - Extract ExternalApplication interface from AppImageFile and add it to the model;
>  - Move LauncherData.ModuleInfo class to the top level;
>  - Add parent interface BundleSpec for Application and Package interfaces in the model;
>  - Merge PackageWriter and ApplicationWriter into BundleCreator interface;
>  - Add BundlingEnvironment, and BundlingOperation interfaces to the model;
>  - Remove LauncherModularStartupInfoMixin.modulePath(). It is not being used;
>  - Remove CollectionUtils.toSet();
> 
> Additionally, fix modifier order in TokenReplace.

src/jdk.jpackage/share/classes/jdk/jpackage/internal/FromParams.java line 106:

> 104:             if (hasPredefinedAppImage(params)) {
> 105:                 final var appImageFile = PREDEFINED_APP_IMAGE_FILE.fetchFrom(params);
> 106:                 appBuilder.initFromExernalApplication(appImageFile, launcherInfo -> {

`Exernal` -> `External`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25477#discussion_r2111081544


More information about the core-libs-dev mailing list