RFR: 8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts

Alexey Semenyuk asemenyuk at openjdk.org
Wed May 28 20:02:56 UTC 2025


On Wed, 28 May 2025 19:32:47 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

> - Removed all code from pre- and post- installation PKG scripts.
> - This code is not needed and PKG should create destination folder and set correct permissions.
> - If for some reason it is not happens, permissions issues should be fixed when jpackage prepares application bundle. PKG should keep all permissions unchanged when packaging and installing bundle.
> - pre- and post- installation PKG scripts are kept as empty scripts, so user can override them if needed.
> - `INSTALL_LOCATION` and `APP_LOCATION` substitution is removed, since `$1` argument in scripts is same as `INSTALL_LOCATION`.
> - I think code in these scripts are some legacy leftovers.

Why do we need empty scripts? It doesn't make sense. I'd remove them.

Also, if this area of jpackage is being revisited, then we need a couple of tests for custom PKG scripts.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25510#issuecomment-2917466837


More information about the core-libs-dev mailing list