RFR: 8357690: Add @Stable and final to java.lang.CharacterDataLatin1 and other CharacterData classes [v3]
Shaojin Wen
swen at openjdk.org
Thu May 29 01:00:52 UTC 2025
On Wed, 28 May 2025 19:20:08 GMT, ExE Boss <duke at openjdk.org> wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fix comments, from @natoj
>
> src/java.base/share/classes/java/lang/CharacterData00.java.template line 36:
>
>> 34:
>> 35: final class CharacterData00 extends CharacterData {
>> 36: /* The character properties are currently encoded into 32 bits in the following manner:
>
> Maybe also add the table `B` comment from `GenerateCharacter` to these comments: <https://github.com/openjdk/jdk/blob/28f509317d477c5f4076658f9ae9995aa6c53631/make/jdk/src/classes/build/tools/generatecharacter/GenerateCharacter.java#L158-L171>
That's right, but it should be a separate PR
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25430#discussion_r2112986499
More information about the core-libs-dev
mailing list