RFR: 8358095: Cleanup tests with explicit locale provider set to only CLDR [v2]
Naoto Sato
naoto at openjdk.org
Fri May 30 00:43:52 UTC 2025
On Fri, 30 May 2025 00:20:26 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> Please review this PR which cleans up some i18n tests.
>>
>> There are some i18n related tests that set the locale provider to CLDR (and only CLDR). Since JDK9, this is redundant and equivalent to the default. Thus, occurrences of "-Djava.locale.providers=CLDR" are just extra noise for these tests.
>>
>> As this change is trivial cleanup, bug IDs are not updated in this change.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>
> reflect review: strip othervm mode + cleanup
test/jdk/java/util/TimeZone/Bug8167143.java line 102:
> 100: case "testCompat":
> 101: testImplicitCompatLocales();
> 102: break;
The method name is deceiving, but the test still has value because it tests the internal `FALLBACK` provider. In fact, functions for `BreakIterator` and `Collator` should be fully functional from that provider, as `CLDR` provider does not provide those. Maybe renaming `Compat` to `Fallback` would be appropriate.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25532#discussion_r2114948613
More information about the core-libs-dev
mailing list