Integrated: 8357683: (process) SIGQUIT still blocked after JDK-8234262 with jdk.lang.Process.launchMechanism=FORK or VFORK
Thomas Stuefe
stuefe at openjdk.org
Fri May 30 13:42:59 UTC 2025
On Sat, 24 May 2025 05:49:43 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> See bug description. We now unblock all signals in both FORK and POSIX_SPAWN launch modes. This fixes the problem and makes the behavior consistent across these two modes.
>
> I left the VFORK mode alone since I believe the signal state is still shared with the parent. One more reason to get rid of this mode soon (it's deprecated with 25 and will be removed with 26)
>
> The fix just moves the unblocking code from the jspawnhelper over to the child process function that is called for all three modes.
>
> -----
>
> Testing: I did various manual tests. I also tested that test/jdk/java/lang/ProcessBuilder/UnblockSignals.java succeeds with both POSIX_SPAWN and FORK mode now and that the behavior is unchanged (still broken) for VFORK mode.
>
> ping @RogerRiggs I would like to get this still into JDK 25; the fix is small and clean enough to not worry me.
This pull request has now been integrated.
Changeset: ae3d96a4
Author: Thomas Stuefe <stuefe at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/ae3d96a4ec87262bc2f01d87fe91daa5d0d3966f
Stats: 30 lines in 3 files changed: 20 ins; 6 del; 4 mod
8357683: (process) SIGQUIT still blocked after JDK-8234262 with jdk.lang.Process.launchMechanism=FORK or VFORK
Reviewed-by: rriggs
-------------
PR: https://git.openjdk.org/jdk/pull/25428
More information about the core-libs-dev
mailing list