RFR: 8358015: Fix SequencedMap sequenced view method specifications
Jaikiran Pai
jpai at openjdk.org
Fri May 30 14:37:52 UTC 2025
On Thu, 29 May 2025 00:21:35 GMT, Stuart Marks <smarks at openjdk.org> wrote:
> For a full explanation, see the bug report [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>
> This PR includes three related changes:
> * New overrides in SequencedMap view collection implementations, which improve their behavior.
> * Update to `@implSpec` clauses to reflect this behavior (which was previously ill-specified).
> * Update to a test which relied on unspecified behavior.
Overall this looks good to me. I just have a small question about the newly introduced text.
The copyright years on BasicMap.java and SequencedMap.java will need a update before integrating.
src/java.base/share/classes/java/util/SequencedMap.java line 271:
> 269: * Its {@link SequencedSet#getFirst getFirst} and {@link SequencedSet#getLast getLast}
> 270: * methods are implemented in terms of the {@link #firstEntry firstEntry} and {@link
> 271: * #lastEntry lastEntry} methods of this class, respectively. Its {@link
Hello Stuart, some parts of this and other updated method docs use "this interface", "this map", "this class". Was it intentional to use "this class" in this newly added text?
-------------
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25515#pullrequestreview-2881559356
PR Review Comment: https://git.openjdk.org/jdk/pull/25515#discussion_r2116044744
More information about the core-libs-dev
mailing list