RFR: 8371184: Improve jpackage test coverage for "--app-image" option [v4]
Alexander Matveev
almatvee at openjdk.org
Tue Nov 4 22:03:48 UTC 2025
On Tue, 4 Nov 2025 21:46:49 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
>> - Verify that when `--app-image` option is specified, files from the predefined app image are copied verbatim into the output app image (JPackageCommand: add `PREDEFINED_APP_IMAGE_COPY`).
>> - Add `LauncherVerifier.launcherDescription()` and use it from LiunuxHelper; extend PropertyFinder class for `LauncherVerifier.launcherDescription()`.
>> - Automatically reapply verifications to launchers in the predefined app image to the command referencing the predefined app image through `--app-image` option. Other changes relate to this update.
>>
>> Supplementary:
>> - Clean up redundancies after [8351369: [macos] Use --install-dir option with DMG packaging](https://bugs.openjdk.org/browse/JDK-8351369) fix: remove `JPackageCommand.dmgInstallDir`, simplify InstallDirTest test.
>> - AppContentTest.java: fix to make test logs stable.
>
> Alexey Semenyuk has updated the pull request incrementally with two additional commits since the last revision:
>
> - run ./bin/blessed-modifier-order.sh
> - Fix a typo
Latest changes looks good.
-------------
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28118#pullrequestreview-3418772974
More information about the core-libs-dev
mailing list