RFR: 8371645: BasicImageReader getEntryNames() is stateful and cannot be called more than once

Alan Bateman alanb at openjdk.org
Wed Nov 12 13:57:04 UTC 2025


On Wed, 12 Nov 2025 11:17:21 GMT, David Beaumont <duke at openjdk.org> wrote:

> Stop entry name creation using a stateful read of underlying buffer (which moves the position and consumes it).

Marked as reviewed by alanb (Reviewer).

The change looks okay, the only usage I can find in the src tree if the jimage too.

Can you add the "noreg-hard" label to the JBS issue as it doesn't seem feasible to include a regression test.

-------------

PR Review: https://git.openjdk.org/jdk/pull/28263#pullrequestreview-3453574021
PR Comment: https://git.openjdk.org/jdk/pull/28263#issuecomment-3522066837


More information about the core-libs-dev mailing list