RFR: 8366224: Introduce DecimalDigits.appendPair for efficient two-digit formatting and refactor DateTimeHelper [v18]
Shaojin Wen
swen at openjdk.org
Thu Nov 13 06:04:12 UTC 2025
On Thu, 13 Nov 2025 04:16:28 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Shaojin Wen has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - fix codestyle
>> - digitQuad MergeStore & from @liach
>
> test/jdk/jdk/internal/util/DecimalDigitsTest.java line 36:
>
>> 34: * @summary Test DecimalDigits.appendPair method with LATIN1 and UTF16 encoding
>> 35: * @modules java.base/jdk.internal.util
>> 36: * @run testng test.jdk.internal.util.DecimalDigitsTest
>
> We recommend using junit for new tests.
import org.junit.jupiter.api.Test;
import static org.junit.jupiter.api.Assertions.assertEquals;
Using JUnit 5 will cause an error:
/Users/wenshao/Work/git/jdk/test/jdk/jdk/internal/util/DecimalDigitsTest.java:27: error: package org.junit.jupiter.api does not exist
import static org.junit.jupiter.api.Assertions.assertEquals;
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26911#discussion_r2521691404
More information about the core-libs-dev
mailing list