RFR: 8371682: Suppress javac warning from ThreadPoolExecutorSubclassTest.java
Alan Bateman
alanb at openjdk.org
Thu Nov 13 07:21:03 UTC 2025
On Thu, 13 Nov 2025 02:31:31 GMT, SendaoYan <syan at openjdk.org> wrote:
> Hi all,
>
> In JDK 11, ThreadPoolExecutor.finalize() was specified to do nothing, leaving the finalize() method empty by [JDK-8371748](https://bugs.openjdk.org/browse/JDK-8371748), so I think it's safety to remove finalize() in testFinalizeMethodCallsSuperFinalize for test/jdk/java/util/concurrent/tck/ThreadPoolExecutorSubclassTest.java.
>
> This PR also remove unnecessary '@SuppressWarnings("removal")' in test/jdk/java/util/concurrent/tck/JSR166TestCase.java and test/jdk/java/util/concurrent/tck/ExecutorsTest.java.
>
> Change has been verified locally on linux-x64 by run test ava/util/concurrent/tck/JSR166TestCase.java#default. Test-fix only, no risk,
I think the changes in this PR are okay. I think it is time to remove TPE.finalize too (not this PR of course).
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28278#issuecomment-3525980634
More information about the core-libs-dev
mailing list