RFR: 8347831: Re-examine version check when cross linking [v7]
Alan Bateman
alanb at openjdk.org
Fri Nov 14 13:43:41 UTC 2025
On Fri, 14 Nov 2025 10:10:21 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> Henry Jen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> remove the extra space
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties line 133:
>
>> 131: err.empty.module.path=No module found in module path ''{0}'' with --add-modules ALL-MODULE-PATH
>> 132: err.limit.modules=--limit-modules not allowed with --add-modules ALL-MODULE-PATH
>> 133: err.jlink.version.mismatch=jlink build {0} does not match target java.base build {1}
>
> It would be good if the build info in the error is quoted. It's otherwise hard to discern where the build info starts/ends in the message:
>
> Suggestion:
>
> err.jlink.version.mismatch=jlink build ''{0}'' does not match target java.base build ''{1}''
I agree as there are several sub-components in this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28155#discussion_r2527545554
More information about the core-libs-dev
mailing list