RFR: 8366224: Introduce DecimalDigits.appendPair for efficient two-digit formatting and refactor DateTimeHelper [v24]

Shaojin Wen swen at openjdk.org
Fri Nov 14 15:48:16 UTC 2025


> This PR introduces a new efficient API for appending two-digit integers to StringBuilders and refactors DateTimeHelper to leverage this new functionality.
> 
> Changes include:
> 
> 1. New `appendPair` method for efficient two-digit integer formatting (00-99):
>    - Added `AbstractStringBuilder.appendLatin1(char c1, char c2)` with core implementation
>    - Added `JavaLangAccess.appendPair(StringBuilder, char c1, char c2)` for internal access
>    - Added `DecimalDigits.appendPair(StringBuilder, int)` public static utility method
>    - Enhanced Javadoc documentation for all new methods
> 
> 2. Refactored `DateTimeHelper` to use the new `DecimalDigits.appendPair`:
>    - Updated `DateTimeHelper.formatTo` methods for `LocalDate` and `LocalTime`
>    - Replaced manual formatting logic with the new efficient two-digit appending
>    - Improved code clarity and consistency in date/time formatting
> 
> These changes improve code clarity and performance when formatting two-digit numbers, particularly in date/time formatting scenarios.

Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:

  add test and from @RogerRiggs

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/26911/files
  - new: https://git.openjdk.org/jdk/pull/26911/files/0abf226b..0070e7b3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=26911&range=23
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=26911&range=22-23

  Stats: 37 lines in 1 file changed: 29 ins; 3 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/26911.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/26911/head:pull/26911

PR: https://git.openjdk.org/jdk/pull/26911


More information about the core-libs-dev mailing list