RFR: 8333727: Use JOpt in jpackage to parse command line [v6]

Alexey Semenyuk asemenyuk at openjdk.org
Fri Nov 14 18:57:09 UTC 2025


On Fri, 14 Nov 2025 02:00:51 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   MainResources.properties: remove unreferenced L10N key
>
> src/jdk.jpackage/share/classes/jdk/jpackage/internal/cli/StandardValidator.java line 48:
> 
>> 46:     static final Predicate<Path> IS_DIRECTORY = Files::isDirectory;
>> 47: 
>> 48:     static final Predicate<Path> IS_EXISTENT_NOT_DIRECTORY = path -> {
> 
> `IS_EXISTENT_NOT_DIRECTORY` will be same as `IS_REGULAR_FILE`? And just do `return Files. isRegularFile(path)`.

`IS_EXISTENT_NOT_DIRECTORY` means it can be a regular file or a symlink.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28163#discussion_r2528583051


More information about the core-libs-dev mailing list