RFR: 8333727: Use JOpt in jpackage to parse command line [v6]

Brian Burkhalter bpb at openjdk.org
Sat Nov 15 01:20:10 UTC 2025


On Sat, 15 Nov 2025 00:48:54 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> In this case should it be something like below? Sounds more clear to me.
>> 
>> ``` 
>> static final Predicate<Path> IS_FILE_OR_SYMLINK = path -> {
>>         return Files.isRegularFile(path) || Files.isSymbolicLink(path);
>> };
>
> It isn't particularly clear to me, but I trust your fresh look. Will update you as suggested.

Not my area here, but `IS_FILE_OR_SYMLINK` sounds good to me (as a NIO maintainer).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28163#discussion_r2529360710


More information about the core-libs-dev mailing list