RFR: 8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests
SendaoYan
syan at openjdk.org
Sat Nov 15 04:09:01 UTC 2025
On Sat, 8 Nov 2025 08:10:45 GMT, SendaoYan <syan at openjdk.org> wrote:
> Hi all,
>
> The DockerTestUtils.RETAIN_IMAGE_AFTER_TEST variable which read the property from "jdk.test.docker.retain.image" do not work for some of the docker tests, such as jdk/internal/platform/docker/TestDockerCpuMetrics.java, only works for some of the docker tests, such as jdk/internal/platform/docker/TestPidsLimit.java.
>
> This PR read the DockerTestUtils.RETAIN_IMAGE_AFTER_TEST inside function removeDockerImage instead of before all the fucntion removeDockerImage. This will make all the docker tests receive the property jdk.test.docker.retain.image.
>
> Change has been verified locally on linux-x64 by run the all touched tests.
Looking for 2rd reviewer, since this PR touch files in hotspot directory.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28208#issuecomment-3535663799
More information about the core-libs-dev
mailing list