RFR: 8371960: Missing null check in AnnotatedType annotation accessor methods
Chen Liang
liach at openjdk.org
Tue Nov 18 15:16:51 UTC 2025
On Sun, 16 Nov 2025 16:02:58 GMT, Chen Liang <liach at openjdk.org> wrote:
> `AnnotatedElement` methods specify they throw NPE if they take any null argument: `isAnnotationPresent`, `get(Declared)Annotation`, `get(Declared)AnnnotationsByType`. However, `AnnotatedType` has implementation quality issues that it does not throw NPE for `isAnnotationPresent` and `get(Declared)Annotation`.
>
> This patch fixes this oversight by adding explicit null checks. For `get(Declared)AnnotationsByType`, even though it did throw exceptions, it was in the middle of parsing, so throwing it in the beginning is better.
Thanks for the reviews!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28341#issuecomment-3548094753
More information about the core-libs-dev
mailing list