RFR: 8372047: ClassTransform.transformingMethodBodies andThen composes incorrectly [v3]
Adam Sotona
asotona at openjdk.org
Wed Nov 19 15:19:06 UTC 2025
On Wed, 19 Nov 2025 14:18:53 GMT, Chen Liang <liach at openjdk.org> wrote:
>> ClassMethodTransform and ClassFieldTransform are computing the chaining condition incorrectly - the composed transform should run when any of the component wants to run instead of when all copmonents want to run, and the actual content tranforms can only compose if they apply to the same set of method or fields. So we should restrict this "optimization" to same filters.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>
> Make it clear where the filter is shared
Looks good to me.
-------------
Marked as reviewed by asotona (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28377#pullrequestreview-3483317473
More information about the core-libs-dev
mailing list