RFR: 8372155: RealeaseInfoPlugin doesn't handle input file as UTF-8 properly [v2]

Severin Gehwolf sgehwolf at openjdk.org
Thu Nov 20 11:05:59 UTC 2025


> Please review this simple fix to `jlink`'s `--release-info` plugin to handle non-ASCII in vendor strings. The JDK build uses UTF-8 encoding for the produced `release` file that is being passed to `jlink` at build-time via the `--release-info` plugin. However, the plugin internally uses `java.util.Properties.load(InputStream)` API which assumes `ISO-8859-1` encoding of the input stream. The proposed fix is to use the `java.util.Prorperties.load(Reader)` API instead and pass it an `InputStreamReader` with `UTF-8` encoding.
> 
> Testing:
> - [x] GHA
> - [x] `test/jdk/tools/jlink` tests including the new reg-test which fails prior and passes after the fix.
> 
> Thoughts?

Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:

  Specify that the input file shall be UTF-8

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28399/files
  - new: https://git.openjdk.org/jdk/pull/28399/files/2059e527..2f48c81b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28399&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28399&range=00-01

  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/28399.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28399/head:pull/28399

PR: https://git.openjdk.org/jdk/pull/28399


More information about the core-libs-dev mailing list