RFR: 8321139: jlink's man page does not document the --compress option correctly [v3]
Roger Riggs
rriggs at openjdk.org
Thu Nov 20 14:52:59 UTC 2025
On Thu, 20 Nov 2025 12:57:58 GMT, Ana Maria Mihalceanu <duke at openjdk.org> wrote:
>> src/jdk.jlink/share/man/jlink.md line 67:
>>
>>> 65: : Link service provider modules and their dependencies.
>>> 66:
>>> 67: `-c zip-[0-9]` or `--compress=zip-[0-9]`
>>
>> Nit - the use of square brackets is usually meant to imply "optional". Here it is mandatory to specify a digit between 0 and 9 following the "zip-" text. Perhaps using angular bracket would be better?
>>
>> -c zip-<0-9> or --compress=zip-<0-9>
>
> Good point. Thank you.
> Nit - the use of square brackets is usually meant to imply "optional". Here it is mandatory to specify a digit between 0 and 9 following the "zip-" text. Perhaps using angular bracket would be better?
Hmmm, square brackets in the shell are a regex indicating a wildcard. I think that `[0-9]` reads better in the shell/command line context.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28359#discussion_r2546361650
More information about the core-libs-dev
mailing list