RFR: 8372290: jpackage test lib improvements [v2]
Alexander Matveev
almatvee at openjdk.org
Fri Nov 21 04:23:26 UTC 2025
On Thu, 20 Nov 2025 18:48:29 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
>> Collect updates to jpackage test lib from different work-in-progress fixes:
>>
>> - ConfigFilesStasher: fix "ServiceTest.testAddLFromAppImage" test failure on Linux
>> - Move PropertyFile class to the package level and make it not throw IOException
>> - Update test/jdk/tools/jpackage/clean_stashed_files.sh and test/jdk/tools/jpackage/clean_test_output.sh scripts
>> - CannedFormattedString: make it implement CannedArgument; add `addPrefix()`, and `mapArgs()`
>> - JPackageCommand: add `makeError()` and `makeAdvice()`
>>
>> Additionally:
>> - Add a test case to the AppImagePackageTest test to test that jpackage placed launcher .so in the correct location when using the predefined app image and installing the "/usr" tree on Linux
>> - Reduce code duplication in LauncherAsServiceVerifier.java
>
> Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:
>
> AdditionalLauncher: use Slot class
Looks good.
-------------
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28439#pullrequestreview-3491134615
More information about the core-libs-dev
mailing list