RFR: 8321139: jlink's man page does not document the --compress option correctly [v3]

Ana Maria Mihalceanu duke at openjdk.org
Fri Nov 21 10:07:23 UTC 2025


On Fri, 21 Nov 2025 09:38:03 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Ana Maria Mihalceanu has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove extra line.
>>  - Align behavior of compression levels to the input received and sync help+documentation messages.
>
> test/jdk/tools/jlink/TaskHelperTest.java line 226:
> 
>> 224:     }
>> 225: 
>> 226:     record CompressTestCase(String[] tokens, String expectedCompressValue, boolean expectedMainFlag) {}
> 
> Hello Ana, what is the `expectedMainFlag` meant for? I see that every usage of it initializes it to `false`.

Hi Jaikiran,

Thank you for spotting that! I guided myself from the previous tests done there and forgot this parameter. I actually do not need it and will remove it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28359#discussion_r2549216831


More information about the core-libs-dev mailing list