RFR: 8372155: ReleaseInfoPlugin doesn't handle input file as UTF-8 properly [v4]
Severin Gehwolf
sgehwolf at openjdk.org
Mon Nov 24 15:13:33 UTC 2025
On Mon, 24 Nov 2025 14:58:34 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Copyright updates.
>
> test/jdk/tools/jlink/plugins/ReleaseInfoPluginTest.java line 71:
>
>> 69: // release file produced should have IMPLEMENTOR in
>> 70: // UTF-8 encoding
>> 71: var release = image.resolve("release");
>
> I probably wouldn't use `var` here because it's not clear because "release" or the method gives no indication that the type is Path here.
OK. I've changed it to use `Path` instead. Did the same for `image` variable where it's not clear either.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28399#discussion_r2556669843
More information about the core-libs-dev
mailing list