RFR: 8362958: Unnecessary copying / sorting in Streams using Comparator.naturalOrder() [v9]
Chen Liang
liach at openjdk.org
Tue Nov 25 04:01:54 UTC 2025
On Thu, 20 Nov 2025 16:30:56 GMT, Patrick Strawderman <duke at openjdk.org> wrote:
>> When `Comparator.naturalOrder()` was explicitly supplied to a collection such as `TreeSet`, or passed into the `sorted` method of a stream, the sorted characteristic was not preserved, causing unnecessary buffering and duplicate sorting.
>>
>> Example:
>>
>>
>> TreeSet<Integer> sortedSet = new TreeSet<>(Comparator.naturalOrder());
>> sortedSet.add(1);
>> sortedSet.add(2);
>> // SortedOps.OfRef.opWrapSink is not a no-op
>> sortedSet.stream().sorted().forEach(System.out::println);
>>
>> or
>>
>> TreeSet<Integer> sortedSet = new TreeSet<>();
>> sortedSet.add(1);
>> sortedSet.add(2);
>> // SortedOps.OfRef.opWrapSink is not a no-op
>> sortedSet.stream().sorted(Comparator.naturalOrder()).forEach(System.out::println);
>>
>>
>> This PR updates `SortedOps.makeRef` and `StreamOpFlag.fromCharacteristics` to handle the above cases and avoid the unnecessary sort step.
>
> Patrick Strawderman has updated the pull request incrementally with one additional commit since the last revision:
>
> Update copyright year
I have submitted this patch with the latest mainline merged for CI testing.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28226#issuecomment-3573684224
More information about the core-libs-dev
mailing list