RFR: 8364544: Extract the checks of AtomicXxxFieldUpdater into a common place [v4]

Steve Armstrong duke at openjdk.org
Tue Nov 25 04:26:08 UTC 2025


> The three AtomicXxxFieldUpdater classes (AtomicIntegerFieldUpdater, AtomicLongFieldUpdater, and AtomicReferenceFieldUpdater) contain duplicate field validation and access checking logic in their constructors and helper methods.
> 
> This change extracts the common validation and utility methods into a new package-private class FieldUpdaterUtil to eliminate code duplication and improve maintainability.
> 
> Changes:
> - Added new FieldUpdaterUtil class with static utility methods:
>   * validateField() - validates field type, volatile, and static checks
>   * computeAccessClass() - determines correct class for access checks
>   * isSamePackage() - checks if two classes are in same package
>   * isAncestor() - checks classloader delegation chain
> 
> - Updated AtomicIntegerFieldUpdater to use FieldUpdaterUtil
>   * Simplified constructor to use validateField() and computeAccessClass()
>   * Removed duplicate isAncestor() and isSamePackage() methods
> 
> - Updated AtomicLongFieldUpdater to use FieldUpdaterUtil
>   * Simplified constructor to use validateField() and computeAccessClass()
>   * Removed duplicate isAncestor() and isSamePackage() methods
> 
> - Updated AtomicReferenceFieldUpdater to use FieldUpdaterUtil
>   * Simplified constructor to use validateField() and computeAccessClass()
>   * Removed duplicate isAncestor() and isSamePackage() methods
> 
> Existing tests in test/jdk/java/util/concurrent/tck and test/jdk/java/util/concurrent/atomic verify that the refactoring preserves the original behavior.

Steve Armstrong has updated the pull request incrementally with one additional commit since the last revision:

  Fix try-catch block to not wrap IllegalArgumentException
  
  The validation exceptions should be thrown directly to the caller,
  not wrapped in RuntimeException. Only the field lookup and access
  checking code should be in the try-catch block.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28464/files
  - new: https://git.openjdk.org/jdk/pull/28464/files/c9a98483..db099fe9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28464&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28464&range=02-03

  Stats: 31 lines in 1 file changed: 11 ins; 9 del; 11 mod
  Patch: https://git.openjdk.org/jdk/pull/28464.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28464/head:pull/28464

PR: https://git.openjdk.org/jdk/pull/28464


More information about the core-libs-dev mailing list