RFR: 8321139: jlink's man page does not document the --compress option correctly [v7]
Ana Maria Mihalceanu
duke at openjdk.org
Wed Nov 26 07:54:29 UTC 2025
On Wed, 26 Nov 2025 05:28:16 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Ana Maria Mihalceanu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Move test for invalid values from TaskHelperTest to JLinkTest.
>
> test/jdk/tools/jlink/JLinkTest.java line 361:
>
>> 359: }
>> 360:
>> 361: // short command without argument- JDK-8321139
>
> We don't usually include JBS bug ids in code comments. For tests which are related to a bug fix, like this one, we include the bug id in the `@bug` tag of the test definition https://openjdk.org/jtreg/tag-spec.html.
>
> This `JLinkTest`, unfortunately has a pre-existing problem that it uses `@bug` more than once (which as per the `@bug` tag specification, isn't correct). So you will have to do some extra work with this one and address that part too. Ultimately, for this test, the `@bug` should now be:
>
>
> @bug 8189777 8194922 8206962 8240349 8321139
>
> While at it, please also update the `@bug` line in `TaskHelperTest` to include 8321139.
Good Morning,
For `JLinkTest `, I noticed more bug IDs among other comments so I added those to `@bug`. I added the new bug ID to `TaskHelperTest `. Please let me know if there is some other comment that I should modify/remove.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28359#discussion_r2563786452
More information about the core-libs-dev
mailing list