RFR: 8321139: jlink's man page does not document the --compress option correctly [v7]
Ana Maria Mihalceanu
duke at openjdk.org
Wed Nov 26 07:59:01 UTC 2025
On Wed, 26 Nov 2025 05:20:42 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Ana Maria Mihalceanu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Move test for invalid values from TaskHelperTest to JLinkTest.
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties line 69:
>
>> 67: main.opt.bind-services=\
>> 68: \ --bind-services Link in service provider modules and\n\
>> 69: \ their dependencies
>
> I think we should leave this change (here and in one other place) out of this PR. There's https://bugs.openjdk.org/browse/JDK-8337422 which is tracking this and there's some discussion in that issue, which indicates that it's OK to do this change. But I think we should do it as part of JDK-8337422.
Thank you for spotting this. I reverted this change as it will be addressed by [JDK-8337422](https://bugs.openjdk.org/browse/JDK-8337422).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28359#discussion_r2563806332
More information about the core-libs-dev
mailing list