RFR: 8372301: Improve error message for jimage command line tool regarding version mismatch [v3]
David Beaumont
duke at openjdk.org
Wed Nov 26 16:46:41 UTC 2025
> Adds a semantic reason for failure which can be optionally interrogated by calling code.
> Use the 'Reason.BAD_VERSION' value to trigger a different translated error message from the JImageTask.
>
> I would consider moving the error message string into the Reason enum to simplify the code triggering the error and avoid message string duplication, but it's not straightforward due to the need to supply the version numbers.
>
> We can use this approach to provide translated messages for all the distinct failure reasons if needed.
David Beaumont has updated the pull request incrementally with two additional commits since the last revision:
- Redo bad indentation
- undo blank line
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/28456/files
- new: https://git.openjdk.org/jdk/pull/28456/files/e1d411f9..32db09a3
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=28456&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=28456&range=01-02
Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/28456.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/28456/head:pull/28456
PR: https://git.openjdk.org/jdk/pull/28456
More information about the core-libs-dev
mailing list