RFR: 8368985: Small Float16 refactorings
Eirik Bjørsnøs
eirbjo at openjdk.org
Wed Oct 1 06:45:46 UTC 2025
On Wed, 1 Oct 2025 04:29:56 GMT, Joe Darcy <darcy at openjdk.org> wrote:
> A few more small cleanups to Float16 and its tests.
src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java line 736:
> 734: final short bits = float16ToRawShortBits(f16);
> 735: // A NaN value has all ones in its exponent and a non-zero significand
> 736: return ((bits & EXP_BIT_MASK) == 0x7c00 && (bits & SIGNIF_BIT_MASK) != 0);
Should the leftover 0x7c00 also be replaced with the constant?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27587#discussion_r2393600002
More information about the core-libs-dev
mailing list