RFR: 8368985: Small Float16 refactorings [v3]
Joe Darcy
darcy at openjdk.org
Wed Oct 1 19:59:48 UTC 2025
On Wed, 1 Oct 2025 18:30:25 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:
> Just an observation: Constants in this class are some times qualified using the class name, in other cases not.
>
> This was probably the case before this PR, but the PR seems itself to be a bit inconsistent.
>
> Since the class uses constants from other classes, would it perhaps be beneficial to always use qualified constants?
Hmm. There is a static import of selected individual constants from the companion Float16Consts helper class, which is analagous to {Float, Double}Consts package access helper classes in java.lang.
There are several other constant from that helper class that are _not_ static imported.
I'll be this PR as is and we can consider regularizing how constant access is phrased in a future refactoring. Thanks.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27587#issuecomment-3357911298
More information about the core-libs-dev
mailing list