RFR: 8356202: Cleanup Source code in String Implementation Classes [v2]
Jaikiran Pai
jpai at openjdk.org
Fri Oct 3 05:52:46 UTC 2025
On Thu, 2 Oct 2025 16:17:32 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Code cleanup in java.lang.StringLatin1 and StringUTF16.
>> Remove the `public` qualifier from methods where it is not needed.
>> Remove an unused toBytes method.
>> Remove unused codePointXXX methods.
>> Remove unnecessary casts of primitive types.
>>
>> Some of these are suggested by IntelliJ, if the advice should not be taken, I'll revert and update the IDE settings.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>
> Revert to insensitive.
Hello Roger, it looks like in `StringUTF16` the `public` from `public static String newString(byte[] val, int index, int len)` can be removed too.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27609#issuecomment-3364353805
More information about the core-libs-dev
mailing list