RFR: 8368831: ResourceParsingClassHierarchyResolver.getClassInfo(ClassDesc) throws unspecified UncheckedIOException [v4]
Shaojin Wen
swen at openjdk.org
Fri Oct 3 14:01:49 UTC 2025
On Tue, 30 Sep 2025 23:42:13 GMT, Chen Liang <liach at openjdk.org> wrote:
>> ClassHierarchyResolver provided by users may sporadically run into exceptions due to reasons out of control, such as UncheckedIOException caused by a bad zip header. We should specify that users are allowed to fail their CHR when they encounter a failure when they support a ClassDesc to avoid hiding errors.
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Merge branch 'master' of https://github.com/openjdk/jdk into doc/chr-exception
> - Update src/java.base/share/classes/jdk/internal/classfile/impl/ClassHierarchyImpl.java
>
> Co-authored-by: Adam Sotona <10807609+asotona at users.noreply.github.com>
> - Fix non-IAE propagation
> - Allow ClassHierarchyResolver to throw RuntimeException
src/java.base/share/classes/jdk/internal/classfile/impl/ClassHierarchyImpl.java line 80:
> 78: throw iae;
> 79: } catch (RuntimeException ex) {
> 80: throw new IllegalArgumentException("Could not resolve class " + classDesc.displayName(), ex);
Suggestion:
throw new IllegalArgumentException("Could not resolve class ".concat(classDesc.displayName()), ex);
Avoid using StringBuilder for string concatenation to reduce code size.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27559#discussion_r2402036492
More information about the core-libs-dev
mailing list