RFR: 8356202: Cleanup Source code in String Implementation Classes [v4]

Jaikiran Pai jpai at openjdk.org
Fri Oct 3 15:45:09 UTC 2025


On Fri, 3 Oct 2025 14:51:39 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Code cleanup in java.lang.StringLatin1 and StringUTF16.
>> Remove the `public` qualifier from methods where it is not needed.
>> Remove an unused toBytes method.
>> Remove unused codePointXXX methods.
>> Remove unnecessary casts of primitive types.
>> 
>> Some of these are suggested by IntelliJ, if the advice should not be taken, I'll revert and update the IDE settings.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix indentation on method declarations

Thank you Roger, the updated changes look good to me.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27609#pullrequestreview-3299647588


More information about the core-libs-dev mailing list