RFR: 8368856: Add a method to safely add duration to instant [v7]
Naoto Sato
naoto at openjdk.org
Mon Oct 6 18:48:55 UTC 2025
On Wed, 1 Oct 2025 20:17:00 GMT, Pavel Rappo <prappo at openjdk.org> wrote:
>> We recently [discussed] the possibility of introducing saturating arithmetic for deadline computation. Consider this PR as a starting point. Once we agree on the implementation, I'll file a CSR.
>>
>> I created a method in `Instant` to add `Duration`. One could argue that the proper way would be to go all the way and create a method in `Temporal` to add `TemporalAmount`. Or maybe even expand the functionality, and create an additional method in `Temporal` to subtract `TemporalAmount`.
>>
>> My current thinking is that if we were to do that, there would be a lot of expensive, unused code. Saturating logic seems to be only useful for `Instant` and `Duration`.
>>
>> Even if we decide to extend `Temporal` to add/subtract `TemporalAmount`, it could always be done later. From the perspective of `Instant`, `plus(TemporalAmount)` will be just an overload of `plus(Duration)`.
>>
>> [discussed]: https://mail.openjdk.org/pipermail/core-libs-dev/2025-September/151098.html
>
> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix copy-paste typos
LGTM, but probably it would need more +1s from others. The PR and issue title need to be modified ("Add a method" -> "Add methods")
-------------
PR Review: https://git.openjdk.org/jdk/pull/27549#pullrequestreview-3306601496
More information about the core-libs-dev
mailing list