RFR: 8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts [v7]

Alexander Matveev almatvee at openjdk.org
Mon Oct 6 22:19:49 UTC 2025


On Mon, 6 Oct 2025 19:13:33 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts [v5]
>
> test/jdk/tools/jpackage/macosx/PkgScriptsTest.java line 62:
> 
>> 60:     @Parameter({"TRUE", "FALSE"})
>> 61:     @Parameter({"FALSE", "TRUE"})
>> 62:     @Parameter({"FALSE", "FALSE"})
> 
> Why do we want to run the test without a custom installation script?

I do not see any benefits for it. I will remove it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25510#discussion_r2408832491


More information about the core-libs-dev mailing list