RFR: 8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts [v7]

Alexander Matveev almatvee at openjdk.org
Mon Oct 6 23:38:51 UTC 2025


On Mon, 6 Oct 2025 19:36:03 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts [v5]
>
> test/jdk/tools/jpackage/macosx/PkgScriptsTest.java line 114:
> 
>> 112:         if (exists) {
>> 113:             TKit.assertFileExists(scriptPath);
>> 114:             TKit.assertTrue(Files.isExecutable(scriptPath), String.format
> 
> Should we check that the owner can execute the file instead of checking if the JVM can execute it?

When file is extracted it will be created under current user, but `pkg` will be installed under `root`. I do not know who owns file while inside `pkg`. So, checking that file has execution permission is what we can do.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25510#discussion_r2408970561


More information about the core-libs-dev mailing list