RFR: 8348828: Windows dll loading now resolves symlinks [v5]
Benjamin Peterson
duke at openjdk.org
Tue Oct 7 17:54:22 UTC 2025
> Deep in the bowels of `System.loadLibrary`, `File.getCanonicalPath()` is called on the target library file before it is passed to the system library loading APIs. In JDK-8003887, `File.getCanonicalPath` was altered to resolve symlinks on Windows. This had unintended consequences for passing a symlink to `System.loadLibrary` on Windows. The underlying Windows `LoadLibrary` API inspects the file name passed to it and adds a `.dll` extension if the it is not already present. Thus, if `System.loadLibrary` was given a symlink to a file and that file didn't have a `.dll` extension, `LoadLibrary` try to load nonexistent file and fail.
>
> Fix this problem by appending a `.` to library paths in Windows' `os::dll_load`. This trailing dot inhibits `LoadLibrary`'s own appending behavior.
Benjamin Peterson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last revision:
- fix compilation
- fix grammar
- add dot in os::dll_load rather than NativeLibraries.java
- Merge remote-tracking branch 'origin/master' into nativelibraries-fix
- switch platform helper to be mapToNativeLibraryName
- Merge remote-tracking branch 'upstream/master' into nativelibraries-fix
- fix spelling
- new approach: append . to file name on Windows
- 8348828: Windows dll loading now resolves symlinks
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/24694/files
- new: https://git.openjdk.org/jdk/pull/24694/files/58d644a5..0e4f3ffb
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=24694&range=04
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=24694&range=03-04
Stats: 516304 lines in 7697 files changed: 345477 ins; 116288 del; 54539 mod
Patch: https://git.openjdk.org/jdk/pull/24694.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/24694/head:pull/24694
PR: https://git.openjdk.org/jdk/pull/24694
More information about the core-libs-dev
mailing list