RFR: 8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts [v8]

[Alexey Semenyuk]

On Tue, 7 Oct 2025 23:50:55 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> - Removed pre- and post- installation PKG scripts.
>> - This code is not needed and PKG should create destination folder and set correct permissions.
>> - If for some reason it is not happens, permissions issues should be fixed when jpackage prepares application bundle. PKG should keep all permissions unchanged when packaging and installing bundle.
>> - Users will have ability to provide pre- and post- installation PKG scripts if needed.
>> - `INSTALL_LOCATION` and `APP_LOCATION` substitution is removed, since `$2` argument in scripts is same as `INSTALL_LOCATION`.
>> - I think code in these scripts are some legacy leftovers.
>> - Added test to test that pre- and post-scripts are no longer exist and can be added via `--resource-dir`.
>
> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts [v6]

src/jdk.jpackage/unix/classes/jdk/jpackage/internal/PackageScripts.java line 110:

> 108:                 }
> 109:             }
> 110:             return Optional.ofNullable(null);

private Optional<String> getDefaultPublicName() {
            return defaultName.flatMap(v -> {
                final String wellKnownSuffix = ".template";
                if (v.endsWith(wellKnownSuffix)) {
                    return Optional.of(v.substring(0, v.length() - wellKnownSuffix.length()));
                }
                return Optional.empty();
            });                
        }

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25510#discussion_r2412284993