RFR: 8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts [v10]
Alexander Matveev
almatvee at openjdk.org
Wed Oct 8 02:39:52 UTC 2025
On Wed, 8 Oct 2025 02:14:48 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
>> - Removed pre- and post- installation PKG scripts.
>> - This code is not needed and PKG should create destination folder and set correct permissions.
>> - If for some reason it is not happens, permissions issues should be fixed when jpackage prepares application bundle. PKG should keep all permissions unchanged when packaging and installing bundle.
>> - Users will have ability to provide pre- and post- installation PKG scripts if needed.
>> - `INSTALL_LOCATION` and `APP_LOCATION` substitution is removed, since `$2` argument in scripts is same as `INSTALL_LOCATION`.
>> - I think code in these scripts are some legacy leftovers.
>> - Added test to test that pre- and post-scripts are no longer exist and can be added via `--resource-dir`.
>
> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
>
> 8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts [v8]
8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts [v9]
- Fixed `null` in log message. With this change all `createResource(null)` should call `setPublicName()`. I only found one location in `ScriptRunner`.
Example of log message after fix:
`[19:27:52.205] No default package resource Test-post-image.sh [script to run after application image is populated] (add Test-post-image.sh to the resource-dir to customize).`
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25510#issuecomment-3379352678
More information about the core-libs-dev
mailing list