RFR: 8363979: Add JDK bundle/image validation for --runtime-image option [v2]
Alexey Semenyuk
asemenyuk at openjdk.org
Thu Oct 9 16:12:48 UTC 2025
> - Validate "libjli.dylib" file in the "lib" directory referenced with the `--runtime-image` option.
> - Split "ERR_MissingJLinkOptMacAppStore" error key into "error.invalid-runtime-image-bin-dir" and "error.invalid-runtime-image-bin-dir.advice"; moved new keys to mac-specific string property file.
> - Fix a couple of typos in RuntimeBuilderBuilder and WixSourceConverter classes.
>
> Error messages:
>
> Runtime image "ErrorTest/test.85b994e1/empty-runtime-image" is missing "lib/**/libjli.dylib" file
>
> Runtime image "ErrorTest/test.05a7421a/invalid-runtime-bundle" is missing "Contents/Home/lib/**/libjli.dylib" file
>
> Runtime image "/Users/alexeysemenyuk/jpackage-dev-runtime" should not contain "bin" folder
> Advice to fix: Use --strip-native-commands jlink option when generating runtime image used with --mac-app-store option
Alexey Semenyuk has updated the pull request incrementally with two additional commits since the last revision:
- ErrorTest: better coverage
- MacFromParams: Restore missing imports
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/27701/files
- new: https://git.openjdk.org/jdk/pull/27701/files/a48a3c18..a35bc119
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=27701&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=27701&range=00-01
Stats: 56 lines in 2 files changed: 34 ins; 10 del; 12 mod
Patch: https://git.openjdk.org/jdk/pull/27701.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/27701/head:pull/27701
PR: https://git.openjdk.org/jdk/pull/27701
More information about the core-libs-dev
mailing list