RFR: 8369432: Add Support for JDBC 4.5 MR [v2]
Lance Andersen
lancea at openjdk.org
Fri Oct 10 16:06:03 UTC 2025
On Fri, 10 Oct 2025 14:16:38 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Doc clean up based on feedback
>
> src/java.sql/share/classes/java/sql/Connection.java line 1840:
>
>> 1838: throw new SQLException("Invalid name");
>> 1839: }
>> 1840: }
>
> Have you considered creating a non-public class with the implementations so that we don't have the same implementation in Statement and Connection? This would also provide somewhere to cache the compiled Patterns (a candidate for LazyConstant in the future, not now as the java.sql does not participate in preview features at this time).
I hadn't but can look at this for follow on clean up before GA and after CSR is approved.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27693#discussion_r2421026721
More information about the core-libs-dev
mailing list