RFR: 8369432: Add Support for JDBC 4.5 MR [v2]
Johannes Döbler
duke at openjdk.org
Sat Oct 11 09:45:02 UTC 2025
On Fri, 10 Oct 2025 16:24:53 GMT, Lance Andersen <lancea at openjdk.org> wrote:
>> test/jdk/java/sql/testng/test/sql/ConnectionTests.java line 39:
>>
>>> 37:
>>> 38: protected StubConnection conn;
>>> 39: protected static String maxIdentifier;
>>
>> You could use `protected static final String MAX_IDENTIFIER = "a".repeat(128);`
>
> Will address as part of the future refactoring of these tests back to Junit
This seems to be a new test, so why not address comments right now, instead of shifting to a refactoring in the future? E.g. this simple change allows you to get rid of the setupClass method and it's a one-minute edit.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27693#discussion_r2422689516
More information about the core-libs-dev
mailing list