RFR: 7105350: HttpExchange's attributes are the same as HttpContext's attributes [v7]

Daniel Fuchs dfuchs at openjdk.org
Mon Oct 13 15:18:45 UTC 2025


On Mon, 13 Oct 2025 14:23:39 GMT, Josiah Noel <duke at openjdk.org> wrote:

>> Now ExchangeImpl will default to having a separate attribute map for the request duration.
>
> Josiah Noel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   doc

src/jdk.httpserver/share/classes/module-info.java line 108:

> 106:  * be accessed by calling getHttpContext().getAttributes(). Set this property to "context"
> 107:  * to restore the pre JDK 26 behavior.
> 108:  * </li></ul>

I would suggest to move that to an `@implNote` - something like:

Suggestion:

 * </li></ul>
 * 
 * @implNote
 * Prior to JDK 26, in the JDK default implementation, the {@link HttpExchange} attribute map was
 * shared with the enclosing {@link HttpContext}.
 * Since JDK 26, by default, exchange attributes are per-exchange and the context attributes must
 * be accessed by calling {@link HttpExchange#getHttpContext() getHttpContext()}
 * {@link HttpContext#getAttributes() HttpContext.getAttributes()}. <br>
 * A new system property, {@systemProperty jdk.httpserver.attributes}</b> (default value: {@code ""})
 * allows to revert this new behavior. Set this property to "context" to restore the pre JDK 26 behavior.
 * 


@Michael-Mc-Mahon what do you think?

(@SentryMan please double check whether some package should imported - or the `{@link }` modified to use full pacakage names for the links to work properly in the generated API doc)

src/jdk.httpserver/share/classes/module-info.java line 111:

> 109:  *
> 110:  * Additional system/networking properties may be defined in the {@code conf/net.properties} configuration file.
> 111:  *

@Michael-Mc-Mahon should we keep that paragraph? It looks like it could be removed now?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27652#discussion_r2426635214
PR Review Comment: https://git.openjdk.org/jdk/pull/27652#discussion_r2426600519


More information about the core-libs-dev mailing list