RFR: 8360025: (se) Convert kqueue Selector Implementation to use FFM APIs

Alan Bateman alanb at openjdk.org
Wed Oct 15 09:28:44 UTC 2025


On Tue, 14 Oct 2025 10:38:01 GMT, Darragh Clarke <dclarke at openjdk.org> wrote:

> This PR was originally part of #25546, though that PR has been split in 2, the first chunk was https://github.com/openjdk/jdk/pull/27590.
> 
> This PR aims to convert KQueue to use FFM apis, the first PR in this area added all the jextract generated code needed, while this PR modifies some of the jextract code and then uses it with Kqueue.
> 
> A brief rundown of the changes:
> - The files `errno_h$shared.java` , `kqueue_h$shared.java`, `timespec_h$shared.java` and `timespec_h.java` have all been deleted. This is because they all contained shared elements that could be moved into the Utility file `FFMUtils.java`
> - `Kqueue.c` has been deleted, and all native methods in the other `KQueue` files have been replaced with references to the generated files kevent and kqueue. This is the bulk of the changes
> - Both the `Kqueue()` and `Kevent()` methods in `kqueue_h.java`  were modified to use adapted method handles that will return the errno value

src/java.base/macosx/classes/sun/nio/ch/KQueue.java line 99:

> 97:      */
> 98:     static long getDescriptor(MemorySegment memoryHandle) {
> 99:         return kevent.ident(memoryHandle);

Do you mind going back over the discussion we had in the original PR? The ident field is a 64-bit, an fd is an int. This means that KQueue should have a getDescriptor that returns an int, or a getIdent that returns a long. The former is cleaner at the use-sites.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27796#discussion_r2431823212


More information about the core-libs-dev mailing list