RFR: 8348844: Remove remaining JVMTI tests from ProblemList-Virtual, use requires instead [v2]
Serguei Spitsyn
sspitsyn at openjdk.org
Thu Oct 16 23:03:07 UTC 2025
On Thu, 16 Oct 2025 02:09:46 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>> The problemlist entries for incompatible tests are replaced with requires tag.
>> Some tests (permissions-related) are not failing anymore. So they are just removed from the problemlist.
>>
>> Tested by running these tests with virtual test tthread factory.
>
> Leonid Mesnik has updated the pull request incrementally with two additional commits since the last revision:
>
> - copyrights updated
> - more tests removed
The fix looks good in general but I've posted a question.
Marked as reviewed by sspitsyn (Reviewer).
test/jdk/ProblemList-Virtual.txt line 63:
> 61: java/util/Properties/StoreReproducibilityTest.java 0000000 generic-all
> 62: javax/management/ImplementationVersion/ImplVersionTest.java 0000000 generic-all
> 63: javax/management/remote/mandatory/version/ImplVersionTest.java 0000000 generic-all
Q: The following tests removed from this Problem-List do not have the required tweaks:
-java/lang/invoke/condy/CondyNestedResolutionTest.java
-jdk/jfr/startupargs/TestDumpOnExit.java
-java/util/Properties/StoreReproducibilityTest.java
-javax/management/ImplementationVersion/ImplVersionTest.java
-javax/management/remote/mandatory/version/ImplVersionTest.java
Is it intentional? Do I miss anything? Could you, please, explain a little bit?
-------------
PR Review: https://git.openjdk.org/jdk/pull/27834#pullrequestreview-3347252960
PR Review: https://git.openjdk.org/jdk/pull/27834#pullrequestreview-3347261953
PR Review Comment: https://git.openjdk.org/jdk/pull/27834#discussion_r2437646036
More information about the core-libs-dev
mailing list