RFR: 8326609: New AES implementation with updates specified in FIPS 197 [v8]

Shawn M Emery duke at openjdk.org
Tue Oct 21 00:21:07 UTC 2025


On Fri, 17 Oct 2025 06:52:16 GMT, Shawn M Emery <duke at openjdk.org> wrote:

>> src/java.base/share/classes/com/sun/crypto/provider/AES_Crypt.java line 976:
>> 
>>> 974:      * @param state [in, out] the round key for inverse mix column processing.
>>> 975:      */
>>> 976:     private static void invMixRKey(int[] state) {
>> 
>> nit: name the method "invMixColumns(int[])". This name matches the spec psuedo code and goes better with the "state" argument name. Or use "invMixRoundKey(int[] roundKey)"?
>
> I've removed this method and inlined this logic in the invGenRoundKeys method.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27807#discussion_r2446428552


More information about the core-libs-dev mailing list